Merged
Conversation
This broke support for engines, which are detected by the path to specs _not_ starting with 'spec/' (e.g. 'my_engine/spec/' instead).
tweaks to ensure relative paths are checked instead of absolute ones, so running within a project with 'spec/' in the path (e.g. neotest-rspec/) doesn't get treated as an engine.
olimorris#49 suggests that some people prefer not to have this functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for running specs for isolated engines was originally added in #34. However, it was broken by a tweak made in #49 that wanted to support running nested spec suites from the project root instead.
I may have got this wrong, but I'm interpreting that as inadvertent breakage for engines (as none of the supporting code was removed), so I'm submitting this PR to restore the original behaviour. As it is evidently not behaviour that everyone prefers, I've suggested an
engine_support = truedefault configuration; those that would rather continue with the "broken" behaviour could change this to opt out. But it could equally make sense to continue with the current behaviour as the default, and allow opt in back to the original enhanced support?I've added some new coverage, as it looks to me like the original coverage got lost during #38.